Skip to content

Feat: New tray-icon that adapts to theme change#33321

Merged
shuaiyuanxx merged 11 commits intomicrosoft:mainfrom
HO-COOH:feat/tray-icon
Jan 8, 2026
Merged

Feat: New tray-icon that adapts to theme change#33321
shuaiyuanxx merged 11 commits intomicrosoft:mainfrom
HO-COOH:feat/tray-icon

Conversation

@HO-COOH
Copy link
Copy Markdown
Contributor

@HO-COOH HO-COOH commented Jun 10, 2024

Summary of the Pull Request

This idea comes from @Shomnipotence. It replaces the old tray icon with a new outlined design and adapts to windows' theme changes.

PR Checklist

  • Closes: #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

This should be obvious enough with the video

2024-06-11.00-02-32.mp4

Validation Steps Performed

  1. Start powertoys, it loads the tray icon of the current theme.
  2. Switch theme in windows settings, it dynamically adapts.

@github-actions

This comment has been minimized.

Sign in to view
@Shomnipotence
Copy link
Copy Markdown

Shomnipotence commented Jun 11, 2024

image
This line drawing style icon will make it consistent with the native UI of the operating system.

@htcfreek
Copy link
Copy Markdown
Collaborator

htcfreek commented Jun 11, 2024

@HO-COOH

  1. Is there an existing issue? If not please create one for discussion and tracking.
  2. Was this ever discussed with the core team?

This was referenced Jun 11, 2024
Closed
Closed
@HO-COOH
Copy link
Copy Markdown
Contributor Author

HO-COOH commented Jun 11, 2024

@HO-COOH

  1. Is there an existing issue? If not please create one for discussion and tracking.
  2. Was this ever discussed with the core team?

I am just here helping out @Shomnipotence to implement what he wanted. For existing issue, see the two referenced by him.

@ayZagen
Copy link
Copy Markdown

ayZagen commented Sep 15, 2024

It looks great, I hope it got merged soon

@yeelam-gordon yeelam-gordon added the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Apr 8, 2025
@akamienski
Copy link
Copy Markdown

akamienski commented Aug 22, 2025

That looks great, now please also do that for Awake tray icon too.

@zadjii-msft zadjii-msft added the Needs-Discussion The team needs to talk about this label Aug 22, 2025
@yeelam-gordon
Copy link
Copy Markdown
Contributor

yeelam-gordon commented Sep 5, 2025

@niels9001, need your input on this PR. Not sure we already consider our new icon for the dark theme work.

@niels9001
Copy link
Copy Markdown
Collaborator

niels9001 commented Nov 3, 2025

@HO-COOH Thanks for raising this PR and apologies for letting it get stale.

I'm fine with these changes - but I think this should be a setting as some people do prefer a colored version. We'd also need to update the outline version of the icon so ensure it matches the PowerToys icon.

Just wanted to check if you're still on point for this PR?

@niels9001 niels9001 added Product-Settings The standalone PowerToys Settings application Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Discussion The team needs to talk about this Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Nov 3, 2025
@HO-COOH
Copy link
Copy Markdown
Contributor Author

HO-COOH commented Nov 3, 2025

@HO-COOH Thanks for raising this PR and apologies for letting it get stale.

I'm fine with these changes - but I think this should be a setting as some people do prefer a colored version. We'd also need to update the outline version of the icon so ensure it matches the PowerToys icon.

Just wanted to check if you're still on point for this PR?

I can add a setting for this feature. As for design wise, please shout out to @Shomnipotence

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Needs-Team-Response An issue author responded so the team needs to follow up and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Nov 3, 2025
@Shomnipotence
Copy link
Copy Markdown

Shomnipotence commented Nov 3, 2025 •
edited
Loading

@HO-COOH Thanks for raising this PR and apologies for letting it get stale.

I'm fine with these changes - but I think this should be a setting as some people do prefer a colored version. We'd also need to update the outline version of the icon so ensure it matches the PowerToys icon.

Just wanted to check if you're still on point for this PR?

I noticed that the colored version of the PowerToys icon hasn't been updated. Was it updated in the preview version?
I guarantee the current version matches the current colored icon.
image

@niels9001
Copy link
Copy Markdown
Collaborator

niels9001 commented Dec 5, 2025 •
edited
Loading

Thanks for the updates. Let's get this in!

@HO-COOH would you mind adding this as a setting on the General page with the colored icon as the default option?

github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 5, 2025
View reviewed changes
@github-actions

This comment has been minimized.

Sign in to view
niels9001
niels9001 reviewed Dec 9, 2025
View reviewed changes
niels9001
niels9001 previously requested changes Dec 9, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@niels9001 niels9001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few UX-related comments :)!

@HO-COOH @niels9001
Apply suggestions from code review
bce16f1 
Co-authored-by: Niels Laute <niels.laute@live.nl>
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@niels9001 niels9001 added In for .97 and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Needs-Team-Response An issue author responded so the team needs to follow up labels Jan 5, 2026
@niels9001
Copy link
Copy Markdown
Collaborator

niels9001 commented Jan 5, 2026

@lei9444 could we get this reviewed and merged for 0.97 :)?

@lei9444
Copy link
Copy Markdown
Contributor

lei9444 commented Jan 8, 2026

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Jan 8, 2026

Azure Pipelines successfully started running 1 pipeline(s).

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 8, 2026
View reviewed changes
@github-actions

This comment has been minimized.

Sign in to view
lei9444
lei9444 approved these changes Jan 8, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@lei9444 lei9444 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shuaiyuanxx helping test and fix. Others LGTM.

@lei9444
Copy link
Copy Markdown
Contributor

lei9444 commented Jan 8, 2026

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Jan 8, 2026

Azure Pipelines successfully started running 1 pipeline(s).

@shuaiyuanxx
Copy link
Copy Markdown
Contributor

shuaiyuanxx commented Jan 8, 2026

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Jan 8, 2026

Azure Pipelines successfully started running 1 pipeline(s).

@shuaiyuanxx shuaiyuanxx dismissed niels9001’s stale review January 8, 2026 06:23

Going to merge, so just dismiss the review.

@shuaiyuanxx shuaiyuanxx merged commit 082ba75 into microsoft:main Jan 8, 2026
11 checks passed
@yeelam-gordon yeelam-gordon added this to the PowerToys 0.97 milestone Jan 12, 2026
@yeelam-gordon yeelam-gordon requested a review from Copilot January 12, 2026 10:22
@HO-COOH HO-COOH review requested due to automatic review settings March 23, 2026 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lei9444 lei9444 lei9444 approved these changes

@vanzue vanzue vanzue approved these changes

@niels9001 niels9001 niels9001 left review comments

@cinnamon-msft cinnamon-msft Awaiting requested review from cinnamon-msft

Assignees

@niels9001 niels9001

@cinnamon-msft cinnamon-msft

Labels

In for .97 Product-Settings The standalone PowerToys Settings application

Projects

None yet

Milestone

PowerToys 0.97

Development

Successfully merging this pull request may close these issues.