Adds mapping object to discriminator objects#170
Merged
irvinesunday merged 13 commits intomasterfrom Feb 8, 2022
Merged
Conversation
baywet
requested changes
Feb 4, 2022
src/Microsoft.OpenApi.OData.Reader/Generator/OpenApiSchemaGenerator.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.OpenApi.OData.Reader/Generator/OpenApiSchemaGenerator.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.OpenAPI.OData.Reader.Tests/Generator/OpenApiSchemaGeneratorTests.cs
Outdated
Show resolved
Hide resolved
…rator.cs Co-authored-by: Vincent Biret <vibiret@microsoft.com>
baywet
reviewed
Feb 7, 2022
Member
baywet
left a comment
There was a problem hiding this comment.
Thanks for taking in the changes, still one thing I'm not super clear about
test/Microsoft.OpenAPI.OData.Reader.Tests/Generator/OpenApiSchemaGeneratorTests.cs
Outdated
Show resolved
Hide resolved
Member
|
@irvinesunday, thanks for making the changes! Would you mind rebasing and handling conflicts before final review please? |
baywet
approved these changes
Feb 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #118
This PR proposes:
mappingobject to the existingdiscriminatorobject in the schemas of structured types which have derived types.Graph.Beta.OData.xmltest file.NB: The
x-ms-discriminator-valueextension which is being added to structured types that are derived types has not been removed so as not to break any existing experience for clients.The
discriminatorobject is enabled from the setting:EnableDiscriminatorValue