Skip to content

Fixed GetAsync method in Rest class #10797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
keveleigh merged 3 commits into from
Oct 4, 2022
Merged

Fixed GetAsync method in Rest class #10797

keveleigh merged 3 commits into from
Oct 4, 2022

Conversation

@Proton-V
Copy link
Contributor

@Proton-V Proton-V commented Jul 28, 2022

Changes

Overview

Fixed problem with using request in Rest.cs class

Fixes

  • ProcessRequestAsync method in Rest.cs

@Proton-V
Copy link
Contributor Author

Proton-V commented Jul 29, 2022

@keveleigh
Hello. I see this warning from azure.
I think you can approve these changes and pipeline will accept branch?

@microsoft microsoft deleted a comment from azure-pipelines bot Jul 29, 2022
@keveleigh
Copy link
Contributor

keveleigh commented Jul 29, 2022

@keveleigh Hello. I see this warning from azure. I think you can approve these changes and pipeline will accept branch?

I'll pull this down and test it out today! Thanks!

@Zee2
Copy link
Contributor

Zee2 commented Aug 23, 2022

@keveleigh updates on this?

@keveleigh
Copy link
Contributor

keveleigh commented Oct 4, 2022

Thanks for this fix! Worked great for me locally.
I pushed one slight change to BytesToString, as I was hitting a null ref in cases where the connection wasn't successful. This change allowed subsequent errors to surface for debugging purposes.

@keveleigh keveleigh self-assigned this Oct 4, 2022
@keveleigh keveleigh merged commit 3c09ff5 into microsoft:main Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@david-c-kline david-c-kline Awaiting requested review from david-c-kline

1 more reviewer

@keveleigh keveleigh keveleigh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@keveleigh keveleigh

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Utilities WebRequestRest Rest.GetAsync() Causes Unity To Hang

5 participants

@Proton-V @keveleigh @Zee2 @david-c-kline @RogPodge