Skip to content

Conversation

@keveleigh
Copy link
Contributor

Overview

Upgrades the "no main camera found, but at least one camera found in the scene" case to an error. There are too many assumptions MRTK would have to make to handle any other case, like auto-tagging existing camera.

Also adds a cache for IsOpaque in some hot loops, which can be expensive.

Changes

@keveleigh keveleigh added the MRTK2 label Jul 7, 2022
@keveleigh keveleigh requested a review from david-c-kline as a code owner July 7, 2022 19:38
@keveleigh keveleigh self-assigned this Jul 7, 2022
@keveleigh keveleigh changed the title Update camera Update CameraCache failure case + perf Jul 7, 2022
@keveleigh keveleigh enabled auto-merge (squash) July 7, 2022 19:39
@keveleigh keveleigh merged commit 1a73ff7 into microsoft:main Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CameraCache.Main Can't Assign Existing Cameras if It Finds Camera.main to be null

2 participants