[2.8.1] perf pass #10643
Merged
[2.8.1] perf pass #10643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
RogPodge
suggested changes
Jun 15, 2022
RogPodge
reviewed
Jun 15, 2022
RogPodge
reviewed
Jun 15, 2022
RogPodge
reviewed
Jun 15, 2022
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
RogPodge
approved these changes
Jun 16, 2022
david-c-kline
left a comment
There was a problem hiding this comment.
question about ValueTuple, otherwise looks good!
| } | ||
|
|
||
| Tuple<Collider, Camera> cameraColliderPair = new Tuple<Collider, Camera>(myCollider, cam); | ||
| ValueTuple<Collider, Camera> cameraColliderPair = ValueTuple.Create(myCollider, cam); |
There was a problem hiding this comment.
ValueTuple is a .net framework 4.7 feature. any thoughts as to whether or not this will break on older unity versions?
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
Validated a successful UWP IL2CPP build in Unity 2018 locally!
RogPodge
approved these changes
Jun 16, 2022
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
CameraFOVChecker,ObjectManipulator,ObjectManipulator, andLRUCacheMicrosoftArticulatedHand,GenericXRSDKController, andFocusProviderat an earlier point where we know there's no work to be doneOpenXRDeviceManager,XRSDKDeviceManager,BaseCursor, andFocusProviderXRSDKDeviceManagerto use theInputDevicesevents instead of polling every frame (which can be expensive for this method)ControllerPoseSynchronizerandFocusProviderto useSetPositionAndRotationin hot loopsObjectManipulatorto not update twice per frame when doing two handed manipulation...LinePointer's line data provider when the pointer isn't active, since there's no need to update a line for an inactive pointerObjectManipulatorto no longer use a dictionary