Skip to content

Conversation

@keveleigh
Copy link
Contributor

Mostly benign reserializations. I'll leave comments on the larger changes!

@keveleigh keveleigh requested a review from RogPodge May 16, 2022 21:23
@keveleigh keveleigh self-assigned this May 16, 2022
@keveleigh keveleigh marked this pull request as ready for review May 16, 2022 21:23
@keveleigh
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

handedness: 7
pointerPrefab: {fileID: 1247086986094436, guid: 51e60b8742bc47640923ac9e75ea74e9,
type: 3}
prioritizedLayerMasks: []
Copy link
Contributor Author

@keveleigh keveleigh May 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RogPodge it looks like pure reserialization doesn't update this properly, I think because we currently only set this in the custom inspector. I'm investigating using ISerializationCallbackReceiver instead

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😬 ouch, hopefully it's easily migratable.

@keveleigh keveleigh merged commit 44805e6 into microsoft:prerelease/2.8.0 May 17, 2022
@keveleigh keveleigh deleted the fix-hand-joint-chaser branch May 17, 2022 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants