Fixing Oculus Deployment Issue, whitespace error #10584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
keveleigh
reviewed
May 16, 2022
Assets/MRTK/SDK/Features/UX/Scripts/Pointers/BaseControllerPointer.cs
Outdated
Show resolved
Hide resolved
keveleigh
reviewed
May 16, 2022
| List<string> warningNumbers = new List<string>(); | ||
|
|
||
| // List of new warning numbers to add to the csc file | ||
| // Empty as of Oculus Integration 39.0 https://developer.oculus.com/downloads/package/unity-integration/39.0 |
Contributor
There was a problem hiding this comment.
Is this comment still accurate? I also still have an open comment (along with some others) about this on a previous PR: #10576 (comment)
Contributor
Author
There was a problem hiding this comment.
Addressed the comments in the other PR.
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
keveleigh
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When deploying to Oculus the 618 error will still pop up, this adds that code to the csc to fix that issue.
Fixed some whitespace that was introduced accidentally.