Build window fixes rollup (10536 && 10571) #10575
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…request" This reverts commit cd96480.
MaxWang-MS
reviewed
May 4, 2022
| currentConnection.IP = EditorGUILayout.TextField(IPAddressLabel, currentConnection.IP, GUILayout.Width(HALF_WIDTH)); | ||
| if (GUILayout.Button("Connect over USB", GUILayout.Width(128f))) | ||
| { | ||
| Application.OpenURL("https://docs.microsoft.com/en-us/windows/mixed-reality/develop/advanced-concepts/using-the-windows-device-portal#connecting-over-usb"); |
Contributor
There was a problem hiding this comment.
Please remove en-us/ from the URL.
This was referenced May 4, 2022
Merged
keveleigh
reviewed
May 12, 2022
| { | ||
| using (var c = new EditorGUI.ChangeCheckScope()) | ||
| { | ||
| string target = IsHoloLensConnectedUsb ? HOLOLENS_USB : DeviceInfo.LocalMachine; |
Contributor
There was a problem hiding this comment.
I've been thinking through this, and Local is also used to deploy things like x64 to your local PC for VR. I'm not sure removing it wholesale like this is the best move. I might be missing it, but I don't see a new codepath restoring this feature.
| { | ||
| using (var c = new EditorGUI.ChangeCheckScope()) | ||
| { | ||
| string target = IsHoloLensConnectedUsb ? HOLOLENS_USB : DeviceInfo.LocalMachine; |
Contributor
There was a problem hiding this comment.
I've been thinking through this, and Local is also used to deploy things like x64 to your local PC for VR. I'm not sure removing it wholesale like this is the best move. I might be missing it, but I don't see a new codepath restoring this feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is a combination of two related PRs (#10536 && #10571). It was created to help validate the changes in both work together as expected.
Fixes: #10406 and #10322