Update TetheredPlacement.cs to use local pose #10566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
david-c-kline
suggested changes
May 3, 2022
| float distanceSqr = (localRespawnPosition - transform.localPosition).sqrMagnitude; | ||
|
|
||
| if (distanceSqr > DistanceThreshold * DistanceThreshold) | ||
| if (distanceSqr > distanceThresholdSquared) |
There was a problem hiding this comment.
With this change, updates to DistanceThreshold do not get applied (distanceThresholdSquared is only calculated in Start)
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
david-c-kline
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
As the scene can be dragged around, the platform the objects should sit on can move around, causing the objects to respawn into nothingness.
This change allows the objects to remember their relative poses and correctly spawn back above the platform.