Add synchronous CloseImmediate() functions to IProgressIndicator #10323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some UI in our application cannot be easily deactivated asynchronously. In particular, we determine the visibility of a child window based on if there are any active `GameObject` children. We've added a synchronous `CloseImmediate()` function to turn the `GameObject off immediately and set the appropriate state.
keveleigh
reviewed
Nov 18, 2021
Assets/MRTK/SDK/Features/UX/Scripts/ProgressIndicators/ProgressIndicatorObjectDisplay.cs
Show resolved
Hide resolved
Assets/MRTK/SDK/Features/UX/Scripts/ProgressIndicators/ProgressIndicatorLoadingBar.cs
Show resolved
Hide resolved
Assets/MRTK/SDK/Features/UX/Scripts/ProgressIndicators/ProgressIndicatorOrbsRotator.cs
Show resolved
Hide resolved
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
…RealityToolkit-Unity into jonathoncobb/progress-indicator-close
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
RogPodge
approved these changes
May 16, 2022
keveleigh
reviewed
May 16, 2022
| /// <summary> | ||
| /// Closes the progress indicator immediately. No fade out animation. All gameObjects for the progress indicator are reset to the correct values. | ||
| /// </summary> | ||
| void CloseImmediate(); |
Contributor
There was a problem hiding this comment.
Changing the interface will be a breaking change. Do we feel okay with that for this scenario?
Contributor
There was a problem hiding this comment.
I think it's fine for this scenario. This component doesn't have a very large scope and it should be easy to implement for users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Some UI in our application cannot be easily deactivated asynchronously. In particular, we determine the visibility of a child window based on if there are any active
GameObjectchildren.Changes
We've added a synchronous
CloseImmediate()function to turn the `GameObject off immediately and set the appropriate state.