Skip to content

Adding the scene reorientation functionality #10100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
RogPodge merged 18 commits into from
May 21, 2022
Merged

Adding the scene reorientation functionality #10100

RogPodge merged 18 commits into from
May 21, 2022

Conversation

@cre8ivepark
Copy link
Contributor

@cre8ivepark cre8ivepark commented Jul 21, 2021 •
edited
Loading

Overview

Based on the feedback, adding re-center functionality to MRTK Examples Hub.

  • Added ReorientContent() to MixedRealitySceneContent.cs
  • Updated ToggleFeaturesPanelExamplesHubStore.prefab for Examples Hub to include reorient functionality.
    • Re-Center button added
    • ReorientContent.cs added which calls MixedRealitySceneContent.ReorientContent()

How to test

Run MRTKExamplesHub scene. Use the 'Re-Center' button on the floating menu to test reorientation.

2021-07-20 20_54_00-Unity 2018 4 35f1 - PREVIEW PACKAGES IN USE - MRTKExamplesHub unity - MixedRea

Changes

@cre8ivepark
Adding ReorientContent() to MixedRealitySceneContent.cs Updating Togg…
6351e8a 
…leFeaturesPanel for Examples Hub to include reorient functionality.
@cre8ivepark
Copy link
Contributor Author

cre8ivepark commented Jul 21, 2021

Need help: Currently, it does not give content proper z offset from the user since it uses camera position.

@cre8ivepark cre8ivepark requested a review from keveleigh July 21, 2021 21:42
@keveleigh keveleigh requested a review from RogPodge July 22, 2021 15:31
@cre8ivepark cre8ivepark marked this pull request as ready for review August 12, 2021 19:48
@cre8ivepark
Copy link
Contributor Author

cre8ivepark commented Aug 12, 2021

@RogPodge
Currently, when the Re-Center button is pressed, it becomes like this (too close to the user)
2021-08-12 12_46_55-Window

Wanted to maintain proper z-position as well. Something like this:
2021-08-12 12_47_03-Window

@cre8ivepark
Copy link
Contributor Author

cre8ivepark commented Aug 12, 2021

It works well! I just tested with HandInteractionExample scene with Align with Head Pose option and it works well even after Hub Menu was reoriented. Thanks @RogPodge !

@cre8ivepark
Updating example scenes to have proper MixedRealitySceneContent objec…
9c1311b 
…t with (0,0,0) position and set Alignment Type 'Align with head pose'
@cre8ivepark
Copy link
Contributor Author

cre8ivepark commented Aug 14, 2021

WORK-IN-PROGRESS

Updating example scenes to have proper MixedRealitySceneContent object with (0,0,0) position and set Alignment Type 'Align with head pose'

@cre8ivepark
Copy link
Contributor Author

cre8ivepark commented Aug 14, 2021

@RogPodge Somehow, reorientation does not work in the device. Not sure if there is any non-device specific code for reorientation?

@david-c-kline
Copy link

david-c-kline commented Feb 23, 2022

@RogPodge, can you sync with @cre8ivepark and see if you can push it over the finish line? Thx!

@RogPodge RogPodge changed the base branch from main to prerelease/2.8.0 May 16, 2022 22:53
@RogPodge
Copy link
Contributor

RogPodge commented May 20, 2022

FInally vetted it all and it looks good, will merge as soon as it passes CI

@RogPodge
Copy link
Contributor

RogPodge commented May 20, 2022

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented May 20, 2022

Azure Pipelines successfully started running 2 pipeline(s).

@RogPodge
Copy link
Contributor

RogPodge commented May 20, 2022

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented May 20, 2022

Azure Pipelines successfully started running 2 pipeline(s).

@RogPodge RogPodge merged commit 1b157fb into microsoft:prerelease/2.8.0 May 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keveleigh keveleigh Awaiting requested review from keveleigh

@CDiaz-MS CDiaz-MS Awaiting requested review from CDiaz-MS

@david-c-kline david-c-kline Awaiting requested review from david-c-kline

@julenka julenka Awaiting requested review from julenka

1 more reviewer

@RogPodge RogPodge RogPodge approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@RogPodge RogPodge

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Ability to recenter to user in Examples Hub

3 participants

@cre8ivepark @david-c-kline @RogPodge