This repository was archived by the owner on Mar 22, 2022. It is now read-only.
Select audio/video codec via SDP message manipulation#9
Merged
jehumb-havok merged 6 commits intodevfrom Jul 5, 2019
Merged
Conversation
Allow the user to force a specific audio or video codec by tweaking the SDP offer message to remove other codecs. This is a workaround for the fact codec selection is not exposed in the API.
| SdpForceCodecs(message_str, audio_codec_name_str, video_codec_name_str); | ||
| *length = std::min(out_message.size(), *length); | ||
| memcpy(buffer, out_message.c_str(), *length); | ||
| buffer[(*length)++] = '\0'; |
Member
There was a problem hiding this comment.
No way to detect truncation?
Member
Author
There was a problem hiding this comment.
Good catch. I started to add it, and forgot to commit in that PR. Will fix.
stkenned-havok
approved these changes
Jul 5, 2019
This was referenced Feb 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow the user to select a preferred audio and/or video codec by manipulating the SDP offer message
sent to the remote peer to remove all other supported codecs.
If the audio (respectively, video) codec specified is not advertised in the SDP offer message, then all the
original audio (respectively, video) codecs are left as is in the offer, to leave a chance to establish a connection, even with other codecs.
This is a workaround for the absence of API for selecting the codecs directly. This method is also used by the
PeerCCsample project of WebRTC UWP.