This repository was archived by the owner on Mar 22, 2022. It is now read-only.
Merged
Conversation
When compiling UWP wrapper projects individually, the output libs are places in a different folder than when compiled from the Visual Studio solution of WebRTC UWP SDK. Add this alternate folder so that Microsoft.MixedReality.WebRTC.Native.UWP can find the libs it needs to link.
This allows e.g. starting the local video feed after the connection is already established, and by extension stopping and starting it again.
This prevents creating unusable data channels.
stkenned-havok
approved these changes
Jul 8, 2019
This was referenced Feb 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore support for adding and removing data channels to the peer connection.
The data channel is represented by a
DataChannelobject created by the peer connection by calling one of the variants ofAddDataChannelAsync.Fix the
TestAppUWPsample app to use a data channel again for text chat as an example use.Because all data channels use SCTP, the SCTP handshake must be performed during the initial connection, which is disabled by default unless the user calls
AddDataChannelAsyncbefore trying to connect (but, obviously, after thePeerConnectionobject is initialized). So add a failsafe boolean checksctp_negotiated_to prevent creating a data channel without SCTP handshake, which otherwise stays in thekConnectingstate forever for no apparent reason. This helps preventing common errors.Fix a threading bug in
TestAppUWPwithOnLoadedevent not waiting for the peer connection initializing to complete before firing. Also re-add support for renegotiation needed event so that e.g. local video can be toggled on and off even after the connection is established.