Register from path #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/MSBuildLocator/MSBuildLocator.cs
Outdated
| /// path. | ||
| /// </summary> | ||
| /// <param name="msbuildPath"></param> | ||
| public static void RegisterMSbuildPath(string msbuildPath) |
Member
There was a problem hiding this comment.
Should the casing be RegisterMSBuildPath with a capital B? That matches other APIs here.
rainersigwald
requested changes
May 21, 2018
src/MSBuildLocator/MSBuildLocator.cs
Outdated
| /// Add assembly resolution for Microsoft.Build core dlls in the current AppDomain from the specified | ||
| /// path. | ||
| /// </summary> | ||
| /// <param name="msbuildPath"></param> |
Member
There was a problem hiding this comment.
Doc what this is: (absolute?) path to the folder that contains Microsoft.Build.dll?
rainersigwald
approved these changes
May 29, 2018
samples/BuilderApp/Program.cs
Outdated
| MSBuildLocator.RegisterInstance(instanceToUse); | ||
| if (msbuildDeploymentToUse.VSInstance != null) | ||
| { | ||
| Console.WriteLine($"Using MSBuild deployment from VS Instance: {msbuildDeploymentToUse.VSInstance.Name} - {msbuildDeploymentToUse.VSInstance.Version}"); |
Member
There was a problem hiding this comment.
I would not use the word "deployment" here. Just say Using MSBuild from...
AndyGerlicher
approved these changes
May 29, 2018
AndyGerlicher
approved these changes
May 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful if you know exactly where MSBuild is, for example if you want to point it to the msbuild repo bootstrap directory.