Skip to content

Conversation

@YuliiaKovalova
Copy link
Contributor

Fixes: #89

Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work? It looks like it should hit dotnet/msbuild#1155

@ladipro
Copy link
Member

ladipro commented Sep 1, 2023

Does this work? It looks like it should hit dotnet/msbuild#1155

+1, this does not build.

@YuliiaKovalova, in addition to fixing it could you please also add

  <Import Project="..\..\src\MSBuildLocator\build\Microsoft.Build.Locator.targets"/>

to BuilderApp.csproj so this file is covered by CI?

@YuliiaKovalova
Copy link
Contributor Author

YuliiaKovalova commented Sep 1, 2023

Does this work? It looks like it should hit dotnet/msbuild#1155

+1, this does not build.

@YuliiaKovalova, in addition to fixing it could you please also add

  <Import Project="..\..\src\MSBuildLocator\build\Microsoft.Build.Locator.targets"/>

to BuilderApp.csproj so this file is covered by CI?

I was inspired by https://stackoverflow.com/questions/3289538/is-there-any-msbuild-task-to-check-if-a-string-contains-another-string-similar

:) I will doublecheck

Should I check it with a regular expression?

@ladipro
Copy link
Member

ladipro commented Sep 1, 2023

I was inspired by https://stackoverflow.com/questions/3289538/is-there-any-msbuild-task-to-check-if-a-string-contains-another-string-similar

Yes, it works for properties but sadly not for metadata.

Should I check it with a regular expression?

I don't think so. Please check this comment.

@YuliiaKovalova YuliiaKovalova force-pushed the dev/ykovalova/fix_warning_presence branch from a7dc4c3 to 4fdff14 Compare September 1, 2023 10:09
@YuliiaKovalova
Copy link
Contributor Author

I was inspired by https://stackoverflow.com/questions/3289538/is-there-any-msbuild-task-to-check-if-a-string-contains-another-string-similar

Yes, it works for properties but sadly not for metadata.

Should I check it with a regular expression?

I don't think so. Please check this comment.

It works, thank you !

Copy link
Member

@ladipro ladipro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please wait for @rainersigwald's approval before merging.

@YuliiaKovalova
Copy link
Contributor Author

@rainersigwald , please review the changes.

Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I seem to have totally missed this from a couple of weeks ago. LGTM!

@YuliiaKovalova YuliiaKovalova merged commit 6478808 into microsoft:master Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Is it safe to use ExcludeAssets="runtime;contentfiles"?

3 participants