-
Notifications
You must be signed in to change notification settings - Fork 90
update warning presence in Microsoft.Build.Locator.targets #233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update warning presence in Microsoft.Build.Locator.targets #233
Conversation
rainersigwald
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this work? It looks like it should hit dotnet/msbuild#1155
+1, this does not build. @YuliiaKovalova, in addition to fixing it could you please also add <Import Project="..\..\src\MSBuildLocator\build\Microsoft.Build.Locator.targets"/>to BuilderApp.csproj so this file is covered by CI? |
I was inspired by https://stackoverflow.com/questions/3289538/is-there-any-msbuild-task-to-check-if-a-string-contains-another-string-similar :) I will doublecheck Should I check it with a regular expression? |
Yes, it works for properties but sadly not for metadata.
I don't think so. Please check this comment. |
a7dc4c3 to
4fdff14
Compare
It works, thank you ! |
ladipro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please wait for @rainersigwald's approval before merging.
|
@rainersigwald , please review the changes. |
rainersigwald
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I seem to have totally missed this from a couple of weeks ago. LGTM!
Fixes: #89