Fixed memory leaks and out of bound access#803
Merged
JordanMaples merged 3 commits intomicrosoft:masterfrom Sep 4, 2019
Merged
Fixed memory leaks and out of bound access#803JordanMaples merged 3 commits intomicrosoft:masterfrom
JordanMaples merged 3 commits intomicrosoft:masterfrom
Conversation
|
|
Contributor
Author
|
@annagrin @JordanMaples any thoughts on this? |
Contributor
|
Maintainers' call: Looks good, thanks. |
|
Sorry for not participating more, at the time git/github was new to me and I did not have the time to get acquinted with it. Then I forgot about it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I looked through all tests with
valgrind --leak-check=full --leak-kinds=alland found some memory errors. So this PR is just minor fixes of ones.Fixes #737. Actually this issue gave me an idea to run valgrind on all files. So thanks to @stayprivates. It's been over a year since this issue is on hold, so i don't know why he/she doesn't PR the solution already.