Based on the cpp core guidelines I expect to be able to write code like this
int length(zstring p);
but with this gsl implementation the code must look like this (at least on my compiler)
int length(zstring<> p);
I infer from the unit tests that this problem is not specific to me or my compiler. See for example:
|
czstring<> str = name.assume_z(); |
Not sure if this is a problem with the core guidelines or the gsl implementation but based on #770 it seems like the type alias shouldn't be templated.
zstring<> is only marginally worse than zstring but the time wasted figuring out why the example code wouldn't compile in practice is my primary concern.
Based on the cpp core guidelines I expect to be able to write code like this
int length(zstring p);but with this gsl implementation the code must look like this (at least on my compiler)
int length(zstring<> p);I infer from the unit tests that this problem is not specific to me or my compiler. See for example:
GSL/tests/string_span_tests.cpp
Line 988 in 8a4b9ed
Not sure if this is a problem with the core guidelines or the gsl implementation but based on #770 it seems like the type alias shouldn't be templated.
zstring<>is only marginally worse thanzstringbut the time wasted figuring out why the example code wouldn't compile in practice is my primary concern.