[c++] Add a new value_size() method to RmwContext for RCU operations#145
Merged
badrishc merged 5 commits intomicrosoft:masterfrom Jul 4, 2019
Merged
[c++] Add a new value_size() method to RmwContext for RCU operations#145badrishc merged 5 commits intomicrosoft:masterfrom
value_size() method to RmwContext for RCU operations#145badrishc merged 5 commits intomicrosoft:masterfrom
Conversation
Collaborator
|
Thanks, this looks reasonable. Since it's a core change we will need a bit more testing so might take some time to merge. Have you done any performance regression tests with the benchmarks? |
Contributor
Author
|
I haven't yet but I may get a chance over the weekend to run the RMW benchmark and compare |
Contributor
Author
|
Hey, I ran the RMW benchmark against https://docs.google.com/spreadsheets/d/1NozTEkdRO1RHmjFBRhT3oxQExCy3TlXPTheyvYBpdhA/edit?usp=sharing Whilst the results suggest an improvement in performance with these modifications, I think the difference isn't statistically significant and suggests that this change would not impact performance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
value_size()method that allows the user to compute the new Value size with respect to the old ValueRmwContextWhy:
Closes #136