Disallow auto from infer types from ResourceDescriptorHeap and SamplerDescriptorHeap#8474
Merged
Merged
Conversation
Contributor
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
tex3d
approved these changes
May 27, 2026
| } | ||
| if (const HLSLDynamicResourceAttr *Attr = | ||
| getAttr<HLSLDynamicResourceAttr>(type)) | ||
| return !Attr->getIsSampler(); |
Contributor
There was a problem hiding this comment.
Optional: I suppose we could avoid a redundant attribute lookup in IsDynamicHeapInitializer by exposing a function IsHLSLDescriptorHeapType that takes a bool &IsSampler. These functions could use that, and so could IsDynamicHeapInitializer.
llvm-beanz
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch builds on top of #8452, by disallowing auto to infer the types being read from dynamic sampler and resource heaps.
Part of: #8450