[spirv] Support SPV_EXT_demote_to_helper_invocation#2773
Merged
ehsannas merged 2 commits intomicrosoft:masterfrom Mar 27, 2020
Merged
[spirv] Support SPV_EXT_demote_to_helper_invocation#2773ehsannas merged 2 commits intomicrosoft:masterfrom
ehsannas merged 2 commits intomicrosoft:masterfrom
Conversation
652a4d4 to
6cffb15
Compare
Contributor
Author
jaebaek
reviewed
Mar 25, 2020
Collaborator
jaebaek
left a comment
There was a problem hiding this comment.
Mostly LGTM.
Just have 2 minor comments.
| spvBuilder.setInsertPoint(newBB); | ||
|
|
||
| // The discard statement can only be called from a pixel shader | ||
| assert(spvContext.isPS()); |
Collaborator
There was a problem hiding this comment.
I am not sure what is the expected behavior from the AST parser, but I think we should print an explicit error message saying "The discard statement can only be called from a pixel shader".
I am just worried what if a user use release build and is not able to recognize it.
| @@ -1,7 +1,9 @@ | |||
| // Run: %dxc -T ps_6_0 -E main | |||
Collaborator
There was a problem hiding this comment.
Why don't we add a test that uses discard; in a vertex shader and check it with the expected error?
jaebaek
approved these changes
Mar 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.