Add dtslint/dts-critic to the monorepo#353
Merged
Conversation
* Fix banned words check and update dts-critic 1. Update to dts-critic 1.2, which no longer requires project urls to include the homepage url specified on npm. 2. Check for banned words for all packages, not just those complex enough to have a package.json. The location of the check was wrong. * Remove handling for project url mismatch from npm-naming * 0.7.7: Fix banned-words check and update dts-critic
previously it was any substring.
I didn't add a test because tslint doesn't support baselines with newlines in them. It works locally, though.
Not all type definitions use `React.createElement` as the jsx pragma. I bumped into this issue when updating `storybook__preact` types as per DefinitelyTyped/DefinitelyTyped#37275 By adding the compiler option `jsxFactory` other pragmas can be used in type definitions
* Add documentation about localTs and expectOnly option * Update `--expectOnly` description According to microsoft/dtslint#244 (comment) Co-Authored-By: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
Thanks to @IvonGoncharov and @lukyth, respectively.
This is important for users that always use --localTs, which means that they never run the code that creates the cache directory as part of installing old versions of typescript.
Check stderr when stdout is empty
To the version that supports TS 4.5.
1. Update some TS usage. 2. Depend on TS internals instead of tsutils for JSDoc. 3. Update name of dtsutil/dts-critic imports.
packages/dtslint/package.json
Outdated
| "watch": "tsc --watch", | ||
| "build": "tsc", | ||
| "lint": "eslint --ext ts src", | ||
| "test": "npm run build && node test/test.js", |
andrewbranch
approved these changes
Dec 1, 2021
Member
andrewbranch
left a comment
There was a problem hiding this comment.
I'm excited this is done 🌟 Thanks!
Member
Author
|
I'll ship this tomorrow morning when I can watch for problems. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lerna import --flatten@definitelytyped/The last four commits are the only new ones.