Implement handling of IRestrictedErrorInfo and map W.F.HResult to System.Exception #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s and CCW for error information interfaces. Implement mapping and wrapping/unwrapping for "language exceptions" that can be called at ABI boundaries.
…d boundary to verify that we correctly propagate the exception through the native section via WinRT's error handling.
Scottj1s
reviewed
Feb 26, 2020
Scottj1s
reviewed
Feb 26, 2020
Member
|
@manodasanW - would you mind reviewing the bits in WinRT.cs, since error origination has some dark corners? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement IRestrictedErrorInfo and ILanguageExceptionErrorInfo support in cswinrt to the same level of support as in .NET today.
Implement custom HR->Exception mappings. Implement support for propagating language-specific exceptions across ABI boundaries using ILanguageExceptionErrorInfo.
Add a type mapping between
Windows.Foundation.HResultandSystem.Exceptionthat uses the above support to map between the two.Do note that there's a testing hole currently around passing another projection's language-specific exception through .NET correctly and back into that projection. C++/WinRT doesn't use the language-specific exception feature of
RoOriginateLanguageException, so I don't have a projection I can test against easily in our setup. I've opened an issue to add support for this to C++/WinRT at microsoft/cppwinrt#533 for parity.Fixes #76