Merged
Conversation
Member
|
First pass looks really good. I will check it out again tomorrow. Two things I would like to see.
Next step is to get the final .NET fix in as well. We should try and validate that leak scenario still exists. I believe the easiest way is to use the |
Scottj1s
approved these changes
Apr 1, 2021
Member
|
(YAY!) |
…to resurrect reference tracker.
Member
Author
|
The 26 WinUI lifetime tests now all pass. |
AaronRobinsonMSFT
approved these changes
Apr 1, 2021
Member
@manodasanW Any luck trying to use that? |
BenJKuhn
approved these changes
Apr 1, 2021
Member
Author
|
@AaronRobinsonMSFT that is on my list to try out and will get back to you once I do. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes in this PR addresses the memory leaks observed in the samples from #781. It is a variant of the changes attempted initially in #673 , but addresses some of the concerns about finalizers on the RCW handling release by moving that to the IObjectReference itself which owns the lifetime. In addition, it makes sure in aggregated scenarios, any QIs don't increment the COM ref count maintained by the CLR and that for non aggregated scenarios XAML is informed of those references.
From testing, these changes seem to demonstrate an improvement and no leaks are observed in the samples in #781
Fixes #413