Fix marshaler selection for managed->abi for arrays of interfaces #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scottj1s
reviewed
Feb 7, 2020
cswinrt/strings/WinRT_Marshal.cs
Outdated
| var inspectable = MarshalInspectable.CreateMarshaler(value, true); | ||
|
|
||
| return _As(inspectable); | ||
| } |
Member
There was a problem hiding this comment.
this code now exists in triplicate (largely). can we refactor and share it from MarshalGeneric?
Member
Author
There was a problem hiding this comment.
I'll take a look and see if there's a good way to refactor it.
Member
Author
There was a problem hiding this comment.
I've refactored these two to be shared. I don't want to also include the struct one since we'd end up losing some perf (and it was make the design slightly more obtuse) since that one will require using typeof() and the System.Runtime.InteropServices.Marshal class which is known to not have the best performance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #61