Escape assembly name when starting with number #2013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that assembly names beginning with a digit are prefixed with an underscore before sanitizing, preventing invalid identifiers.
- Prefixes an underscore when the input starts with a numeric character
- Continues to replace all non-alphanumeric/underscore characters with underscores
Comments suppressed due to low confidence (1)
src/Authoring/WinRT.SourceGenerator/Helper.cs:1241
- Add a unit test for inputs starting with a digit (e.g., "1MyLib") to verify the underscore prefixing behavior is applied correctly.
var prefixedTypeName = Regex.Match(typeName, @"(^\d)").Success ? "_" + typeName : typeName;
Sergio0694
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1880