Implement stub .exe support for apps + WinRT components #1895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manodasanW
reviewed
Jan 16, 2025
jkoritzinsky
approved these changes
Jan 17, 2025
manodasanW
reviewed
Jan 18, 2025
manodasanW
reviewed
Jan 18, 2025
manodasanW
reviewed
Jan 18, 2025
| """); | ||
|
|
||
| // There's three possible cases for this method: | ||
| // There's four possible cases for this method: |
Member
There was a problem hiding this comment.
Should we add a C# exe project to reference the authoring project and set this property to exercise these changes in the build?
manodasanW
approved these changes
Jan 20, 2025
7647097 to
13ac7d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for generating a stub .exe for an app that's merging WinRT components.
We can split the general "stub .exe" feature into two steps:
This uses a normal binary with standard options.
We can optimize the size to skip CRT in a follow up.