Add 'CsWinRTEnableManifestFreeActivation' feature switch #1887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9fa2dc2 to
0c1656c
Compare
0c1656c to
b25b072
Compare
Member
Author
|
Can confirm this trims everything as expected:
Exceptions also work as expected:
|
manodasanW
reviewed
Jan 18, 2025
manodasanW
reviewed
Jan 18, 2025
manodasanW
reviewed
Jan 18, 2025
manodasanW
reviewed
Jan 19, 2025
manodasanW
reviewed
Jan 20, 2025
manodasanW
reviewed
Jan 20, 2025
manodasanW
reviewed
Jan 20, 2025
manodasanW
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the new "CsWinRTEnableManifestFreeActivation" feature switch (enabled by default), which allows disabling the manifest-free fallback path for WinRT activation. When disabled, all fallback code will be removed, and trying to activate a type that is not registered will throw
NotSupportedException. This can be useful to:Ideally, packaged apps should strive to be able to run with this feature switch disabled, for best performance.