Skip to content

Enable support for C# collection expressions #1878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Sergio0694 merged 42 commits into from
Jan 20, 2025
Merged

Enable support for C# collection expressions #1878

Sergio0694 merged 42 commits into from
Jan 20, 2025

Conversation

@Sergio0694
Copy link
Member

@Sergio0694 Sergio0694 commented Nov 24, 2024 •
edited
Loading

Closes #1877
Closes #1661

This PR adds support for collection expressions, see supported scenarios in linked issue.

@Sergio0694 Sergio0694 added the AOT label Nov 24, 2024
@Sergio0694 Sergio0694 changed the title User/sergiopedri/collection expressions support Enable support for C# collection expressions Nov 24, 2024
@Sergio0694 Sergio0694 force-pushed the user/sergiopedri/collection-expressions-support branch 2 times, most recently from e36afc8 to b797de6 Compare November 25, 2024 07:30
@Sergio0694 Sergio0694 marked this pull request as ready for review November 25, 2024 16:48
manodasanW
manodasanW reviewed Nov 25, 2024
View reviewed changes
@Sergio0694 Sergio0694 force-pushed the user/sergiopedri/collection-expressions-support branch from 2b3f80f to 73e2a0b Compare November 26, 2024 03:03
This was linked to issues Nov 26, 2024
Collection expressions passed as IEnumerable don't have vtables generated in AOT #1661
Closed
Collection expression plan for AOT support #1877
Closed
@Sergio0694 Sergio0694 mentioned this pull request Nov 27, 2024
Closed
@Sergio0694
Create WinRTSuppressions.cs
fe321c4
@Sergio0694
Bump Roslyn to 4.8
3d2229c
@Sergio0694
Create CollectionExpressionSuppressor.cs
ee324b5
@Sergio0694
Create CollectionExpressionAnalyzer.cs
9e78cb9
@Sergio0694
Bump Roslyn to 4.9.2
aec1e2b
@Sergio0694
Update 'CollectionExpressionAnalyzer'
38c9ba1
@Sergio0694
Update AotOptimizer.cs
a59e9f9
@Sergio0694
Create CollectionExpressionIDE0300Suppressor.cs
38075b3
@Sergio0694
Create CollectionExpressionIDE0305Suppressor.cs
cd139de
@Sergio0694
Create CollectionExpressionIDE0303Suppressor.cs
99d1eac
@Sergio0694
Add 'SourceGeneratorTest' project
209ef7c
@Sergio0694
Add tests for 'CollectionExpressionAnalyzer'
6870388
@Sergio0694
Fix folder for new tests
32b440b
@Sergio0694
Run new tests in CI
694923c
@Sergio0694
Rename source generator project
827a095
@Sergio0694
Use shared project for generator
aa09f20
@Sergio0694
Add shared .props for generators
a883d78
@Sergio0694
Add Roslyn 4.12 version of the generators
b58d93d
@Sergio0694
Use 'Microsoft.CodeAnalysis.CSharp.Workspaces'
9e90d51
@Sergio0694 Sergio0694 force-pushed the user/sergiopedri/collection-expressions-support branch from c8ce745 to 81d8d22 Compare December 4, 2024 03:40
manodasanW
manodasanW reviewed Jan 18, 2025
View reviewed changes
manodasanW
manodasanW reviewed Jan 18, 2025
View reviewed changes
@Sergio0694 Sergio0694 merged commit b7e3b68 into staging/2.3 Jan 20, 2025
10 checks passed
@Sergio0694 Sergio0694 deleted the user/sergiopedri/collection-expressions-support branch January 20, 2025 22:39
@Sergio0694 Sergio0694 mentioned this pull request Feb 10, 2025
Closed
@Sergio0694 Sergio0694 mentioned this pull request Jun 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manodasanW manodasanW manodasanW approved these changes

Assignees

No one assigned

Labels

AOT

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Collection expression plan for AOT support Collection expressions passed as IEnumerable don't have vtables generated in AOT

3 participants

@Sergio0694 @manodasanW