Skip to content

Conversation

@chenss3
Copy link
Contributor

@chenss3 chenss3 commented Nov 8, 2024

Related to bug #1428

Create more specific diagnostic information when source generator fails. Build will also error so the user cannot use the broken winmd/projection anymore.

Also rerouted the error messages to go to StandardError instead of StandardOutput.

image

@chenss3 chenss3 marked this pull request as ready for review November 11, 2024 18:59
@chenss3 chenss3 requested a review from manodasanW November 11, 2024 18:59
Copy link
Member

@Sergio0694 Sergio0694 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! 👀

@manodasanW manodasanW merged commit b1733e9 into master Dec 7, 2024
9 checks passed
@manodasanW manodasanW deleted the user/chenss3/diagnostic branch December 7, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants