Skip to content

Fix types in attributes being projected as System.Type in WinMD. #1829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
manodasanW merged 1 commit into from
Oct 17, 2024
Merged

Fix types in attributes being projected as System.Type in WinMD. #1829

manodasanW merged 1 commit into from
Oct 17, 2024

Conversation

@dongle-the-gadget
Copy link
Contributor

@dongle-the-gadget dongle-the-gadget commented Oct 15, 2024

Fixes #1570.

It looks like Type is used here as a mistake? Looking at the log, Type is always System.Type, whereas Value is the name of the actual type passed into the argument.

attribute: Windows.Foundation.Metadata.ExclusiveToAttribute(typeof(TestWinMD.DesktopActions))
attribute type: Windows.Foundation.Metadata.ExclusiveToAttribute
attribute constructor: Windows.Foundation.Metadata.ExclusiveToAttribute.ExclusiveToAttribute(System.Type)
atttribute # constructor arguments: 1
atttribute # named arguments: 0
add type: Windows.Foundation.Metadata.ExclusiveToAttribute
adding method reference: .ctor
custom mapping System.Type to System.Type from mscorlib
found # constructors: 1
typed constant kind: Type
typed constant type: System.Type
typed constant value: TestWinMD.DesktopActions

Sergio0694
Sergio0694 approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@Sergio0694 Sergio0694 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙂

@manodasanW
Copy link
Member

manodasanW commented Oct 17, 2024

Thanks, CI passed.

@manodasanW manodasanW merged commit 578f892 into microsoft:master Oct 17, 2024
@dongle-the-gadget dongle-the-gadget deleted the type-in-attribute branch October 17, 2024 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manodasanW manodasanW manodasanW approved these changes

@Sergio0694 Sergio0694 Sergio0694 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Type Arguments in Attributes Are Always System.Type in the WinMD

3 participants

@dongle-the-gadget @manodasanW @Sergio0694