Fix couple issues #1820
Merged
Fix couple issues #1820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
manodasanW
commented
Oct 11, 2024
- Fix warning in embedded scenario and ensure trailing slash in authoring scenario
- Fix source generator to support nullable collections and fix marshaling logic for it
- Fix source generator for non-blittable structs such as HttpProgress where wrong marshaling function was used
Sergio0694
approved these changes
Oct 12, 2024
Member
Sergio0694
left a comment
There was a problem hiding this comment.
LGTM. Have we checked any size regressions on NAOT with this change?
Member
Author
Based on the ccw functional test, there is a 2kb diff from a func getting added for EventRegistrationToken for some reason. But hard coding EventRegistrationToken similar to the other blittables seems to bring a decent improvement as a bunch of funcs get removed. I will do that improvement as a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.