Fixing multiple type definition issue and fixing NotifyCollectionChangedAction issue #1816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
manodasanW
commented
Oct 10, 2024
- The WebView package and the WinAppSDK 1.5 package both can be referenced by someone and have the same types defined in both. One is an RCW generated by CsWinRT while the other is not as it is for netcore3. Our RCW fallback generator tries to make the WinAppSDK version of it trimming safe but given it is defined in multiple places that leads to a compiler error. It would also be a compiler error already if the component itself tried to use that type. So instead of letting them become a compiler error, we just emit a warning / info to call out we weren't able to make it trim safe and the user should update versions if they need that.
- NotifyCollectionChangedAction wasn't marked as blittable when it should have been as seen in Error CS0122: 'NotifyCollectionChangedAction' is inaccessible due to its protection level #1813
… compiler error in the fallback generator
… for the same type in references.
Sergio0694
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.