Fix IsPartial check and escaping of assembly name #1802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sergio0694
approved these changes
Sep 28, 2024
Member
Author
|
Failures are post build infra issues, tests passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-and@in the assembly name when using it for an identifier or namespace. This addresses that.IsPartialcheck wasn't complete where we didn't also check whether the parent classes were partial too to allow for us to generate source. Due to that, we would generate source in such cases leading to a compiler error rather than raising a diagnostic as we did when the type itself wasn't partial.GeneratedCustomBindablePropertyattribute tooFixes #1799
Fixes #1800