Fix source generator for exception types and fix is operator #1682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
manodasanW
commented
Jul 25, 2024
- The source generator was generating code when collections of exceptions were used that didn't compile. This was because exception is a class which gets mapped in WinRT to a value type and they don't have all the same functions. This addresses that and also the issue where the exception marshaler functions were also mismatching which ones to use.
- Also fixing the is operator check when used with collection types whose helper type haven't been registered and is not implemented by the object. Right now, it throws an exception in that scenario when it should just say this object doesn't implement it.
- Also adding DisposeAbiArray which was missing for Uris
Sergio0694
reviewed
Jul 25, 2024
hez2010
reviewed
Jul 25, 2024
Sergio0694
reviewed
Jul 29, 2024
Sergio0694
reviewed
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.