Skip to content

Fix potential type incompatibility for in-proc WinRT components #1610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
manodasanW merged 4 commits into from
May 14, 2024
Merged

Fix potential type incompatibility for in-proc WinRT components #1610

manodasanW merged 4 commits into from
May 14, 2024

Conversation

@hez2010
Copy link
Contributor

@hez2010 hez2010 commented May 12, 2024 •
edited
Loading

We need to treat the object as unmanaged object and create an RCW for this case.

Fixes #1510.

@hez2010 hez2010 force-pushed the fix/invalid-cast branch from 46eebc3 to 378ca8e Compare May 12, 2024 13:37
@hez2010 hez2010 marked this pull request as draft May 12, 2024 13:59
@hez2010 hez2010 marked this pull request as ready for review May 12, 2024 14:10
@hez2010
Copy link
Contributor Author

hez2010 commented May 12, 2024

Can confirm the issue has been fixed:
image

Sergio0694
Sergio0694 requested changes May 12, 2024
View reviewed changes
@hez2010
Copy link
Contributor Author

hez2010 commented May 13, 2024

PTAL.

@hez2010 hez2010 requested review from Sergio0694 and manodasanW May 13, 2024 05:55
@manodasanW
Copy link
Member

manodasanW commented May 13, 2024

I can see this being a feasible solution to this problem with different projections. Going to run the CI pipelines to make sure everything continues to pass.

@hez2010

This comment was marked as resolved.

Sign in to view
@manodasanW
Copy link
Member

manodasanW commented May 13, 2024

Do you think we should handle this in the projection as well? i.e. turning all global::WinRT.ComWrappersSupport.FindObject<T>(thisPtr) into global::WinRT.ComWrappersSupport.FindObject<object>(thisPtr) is T __obj__ ? __obj__ : global::WinRT.ComWrappersSupport.CreateRcwForComObject<T>(thisPtr)

All of the FindObject calls in the generated projections are part of the Do_ABI_ implementations of the various interfaces. I feel like if we are ending up there, we have already decided that is the right interface for the call. If it was for another projection, I feel like it would end up on the helper type for that interface from that projection. Until we find a scenario that impacts those, I would hold off on updating those.

@manodasanW
Copy link
Member

manodasanW commented May 14, 2024

CI passed, thanks for this change.

@manodasanW manodasanW merged commit 1a8e726 into microsoft:master May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manodasanW manodasanW manodasanW approved these changes

@Sergio0694 Sergio0694 Awaiting requested review from Sergio0694

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unable to cast object of type 'TaskToAsyncOperationAdapter' to type 'IAsyncOperation'

3 participants

@hez2010 @manodasanW @Sergio0694