Hard-code the numeric scalar types in CoerceValue and simplify enum marshalling to remove any usage of Convert.ChangeType. #1487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arshalling to remove any usage of Convert.ChangeType. Convert.ChangeType was rooting a significant amount of code that would never be used (such as string.IConvertible.ToDateTime).
Sergio0694
reviewed
Feb 1, 2024
Member
Sergio0694
left a comment
There was a problem hiding this comment.
Looks awesome!! Will share size diffs when the CI finishes 🙂
manodasanW
reviewed
Feb 1, 2024
Member
|
Saves 57 KB!
|
manodasanW
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert.ChangeType was rooting a significant amount of code that would never be used (such as string.IConvertible.ToDateTime).
This PR will allow us to trim a significant amount of code in many cases (IConvertible isn't a commonly used type nowadays).