Seal IObjectReference.TryAs<T> method #1454
Merged
+69
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Saves 186 KB on .NET 9! 🎉
|
a9bb6cb to
f282beb
Compare
manodasanW
reviewed
Jan 24, 2024
f282beb to
e374b40
Compare
manodasanW
approved these changes
Jan 25, 2024
Member
Author
|
Actually saves 253 KB now with the latest changes too! 🎉
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR seals
IObjectReference.TryAs<T>, which was bloating the binary size due to combinatorial generics:Should also be faster, given that the GVM dispatch isn't exactly the best.