Skip to content

Stop preserving interfaces from MarshalInspectable<T> #1452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Sergio0694 merged 5 commits into from
Jan 26, 2024
Merged

Stop preserving interfaces from MarshalInspectable<T> #1452

Sergio0694 merged 5 commits into from
Jan 26, 2024

Conversation

@Sergio0694
Copy link
Member

@Sergio0694 Sergio0694 commented Jan 18, 2024

This PR includes a couple of small tweaks:

  • Stop unnecessarily preserving interfaces for MarshalInspectable<T>
  • Fix a couple of trimming annotations in Marshalers.cs and Type.cs

@Sergio0694 Sergio0694 requested a review from manodasanW January 18, 2024 11:13
@Sergio0694 Sergio0694 force-pushed the user/sergiopedri/drop-interface-kept branch 2 times, most recently from d1bfcaa to 32df75e Compare January 18, 2024 21:49
@Sergio0694 Sergio0694 marked this pull request as draft January 22, 2024 19:58
@Sergio0694 Sergio0694 force-pushed the user/sergiopedri/drop-interface-kept branch from 1d5ed17 to 8d30706 Compare January 22, 2024 20:01
@Sergio0694 Sergio0694 marked this pull request as ready for review January 22, 2024 20:01
@Sergio0694 Sergio0694 force-pushed the user/sergiopedri/drop-interface-kept branch 2 times, most recently from 9056fba to 01f089f Compare January 25, 2024 22:07
@Sergio0694 Sergio0694 force-pushed the user/sergiopedri/drop-interface-kept branch from 01f089f to 4e0877c Compare January 26, 2024 14:27
@Sergio0694 Sergio0694 merged commit ed303ba into staging/AOT Jan 26, 2024
@Sergio0694 Sergio0694 deleted the user/sergiopedri/drop-interface-kept branch January 26, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manodasanW manodasanW manodasanW approved these changes

Assignees

No one assigned

Labels

trimming

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Sergio0694 @manodasanW