Omit non public methods from preserved metadata #1442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24b86a0 to
a9f131f
Compare
Member
Author
|
Saves ~25 KB in a minimal WinRT sample (4225 KB -> 4200 KB):
|
manodasanW
approved these changes
Jan 17, 2024
Also slightly optimize creating delegates for nullable delegates comment
a9f131f to
92e42b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR stops preserving reflection metadata for non public methods of helper types, given that they're:
PublicMethodsas data flow annotations (which also produced warnings)Also including a couple of very minor tweaks to some delegate creations, while at it.