-
Notifications
You must be signed in to change notification settings - Fork 122
Fix test issues discovered from enabling AOT for authoring scenarios #1432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
manodasanW
merged 49 commits into
user/sergiopedri/naot-winrt-exports
from
manodasanw/naot-winrt-exports-authoringtestfixes2
Jan 9, 2024
Merged
Fix test issues discovered from enabling AOT for authoring scenarios #1432
manodasanW
merged 49 commits into
user/sergiopedri/naot-winrt-exports
from
manodasanw/naot-winrt-exports-authoringtestfixes2
Jan 9, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update PR branch
…able entries for some custom mapped types
…ot-winrt-exports-authoringtestfixes
…ot-winrt-exports-authoringtestfixes2
manodasanW
commented
Jan 9, 2024
Sergio0694
approved these changes
Jan 9, 2024
Member
Sergio0694
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple notes, love this! Thank you! 😄
src/cswinrt/strings/additions/Windows.Foundation/TaskToAsyncOperationWithProgressAdapter.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling AOT for authoring scenarios discovered some scenarios that weren't handled. This addresses most of them with one test failure remaining that I am still working on.
IVectorandIVectorView. As part of those implementation, some of those functions return managed objects for which we need to generate a vtable. Some of these are generic objects which this PR handles by making sure those types are on the lookup table if one of the collection types that returns it is used as we do not know which function is going to be called from the native side.IsWinRTTypecheck to also handle types from authoring scenariosWinRTExposedTypeattribute.WinRTExposedTypeattribute was added for.GuidSignaturein the WinRTRuntimeTypeAttribute not being used for authoring types.GetMetadataTokendoesn't work on AOT by replacing withGetHashCodeas we were only using it get a unique value for the type to use as part of a token.WinRTExposedTypeattribute generated for them or the lookup table. Public types worked before as they were handled by the authoring source generator itself.EnsureInitializedis called for them.