Make exported DllGetActivationFactory zero-alloc #1399
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

This PR makes the exported
DllGetActivationFactoryzero-alloc, skipping the uselessstring runtimeClassIdparameter.It does so by introducing the following new API to
MarshalString:This allows marshalling an
HSTRINGto aReadOnlySpan<char>value, without allocating a temporarystring. The "Unsafe" suffix matches the naming convention in the BCL for methods that are not safe when misused. In this case, callers have to make sure not to escape the returnedReadOnlySpan<char>value outside of the scope where theHSTRINGis valid.Then, it updates the generated
Moduletype so that when not on .NET Standard, theGetActivationFactorymethod will actually take aReadOnlySpan<char>parameter (with a secondstringoverload just forwarding to it). The new native exports for NativeAOT can then just call this newReadOnlySpan<char>overload using the newFromAbiUnsafemarshalling method.