Move ActivationFactory into WinRT.Runtime.dll #1390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sergio0694
requested changes
Nov 29, 2023
Sergio0694
requested changes
Jan 23, 2024
Member
|
Just a couple nits but I do love this PR, and the fact |
b2783ce to
9be15b9
Compare
760d15f to
f9b5cd3
Compare
Sergio0694
requested changes
Jan 24, 2024
Member
Sergio0694
left a comment
There was a problem hiding this comment.
Done another review pass on the updated diff 🙂
Sergio0694
reviewed
Jan 25, 2024
Sergio0694
reviewed
Jan 25, 2024
manodasanW
reviewed
Jan 25, 2024
|
|
||
| public static bool TryLoad(string fileName, out DllModule module) | ||
| { | ||
| lock (_cache) |
Member
There was a problem hiding this comment.
It is now more likely that we see parallel calls here due to different threads activating different types. Given these are already cached too, it shouldn't have too much of an impact, but will need to monitor perf traces to see if this shows up and if we need to improve the locking here. But for now, this is fine.
manodasanW
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables additional optimizations that couldn't be done in #1375