Add Context checks to factory caching and simplify factory caching between factories and statics. #1359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e9bfaf3 to
61594c7
Compare
jlaanstra
commented
Sep 15, 2023
…tween factories and statics.
fbd715c to
4ff6df6
Compare
Sergio0694
reviewed
Oct 5, 2023
| private static extern unsafe int CoGetContextToken(IntPtr* contextToken); | ||
|
|
||
| [DllImport("api-ms-win-core-com-l1-1-0.dll")] | ||
| private static extern int CoGetObjectContext(ref Guid riid, out IntPtr ppv); |
Member
There was a problem hiding this comment.
Can we also fix this signature and drop the runtime marshalling while we're at it? 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache factories and statics per context, similar to coreclr/.NET Native behavior.
Fixes #1112