Project Windows.Foundation.EventHandler and fix ICommand event compile break#112
Merged
jkoritzinsky merged 2 commits intomasterfrom Apr 1, 2020
Merged
Project Windows.Foundation.EventHandler and fix ICommand event compile break#112jkoritzinsky merged 2 commits intomasterfrom
jkoritzinsky merged 2 commits intomasterfrom
Conversation
Project MUX.Input.ICommand to System.Windows.Input.ICommand as well. Since WUX.I.ICommand and MUX.I.ICommand share the same IID, this should work seamlessly.
Scottj1s
approved these changes
Apr 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Map
Windows.Foundation.EventHandler<T>toSystem.EventHandler<TEventArgs>.Manually override the type of the
CanExecuteChangedevent handler when emitted by cswinrt to matchICommand's definition. MapMUX.Input.ICommandtoSystem.Windows.Input.ICommandas well since that's something we'll have to do anyway. Since the IIDs always match, this is an easy 2-to-1 mapping to implement.Fixes #111