Skip to content

Add sandbox attribute to YouTube and Vimeo player #4566

@compulim

Description

@compulim

Is it an issue related to Adaptive Cards?

No

Is this an accessibility issue?

No

What version of Web Chat are you using?

Latest production

Which distribution are you using Web Chat from?

Bundle (webchat.js)

Which hosting environment does this issue primarily affect?

Web apps

Which browsers and platforms do the issue happened?

No response

Which area does this issue affect?

Others or unrelated

What is the public URL for the website?

No response

Please describe the bug

We should add sandbox="allow-same-origin allow-scripts" to the YouTube IFRAME video player and Vimeo IFRAME video player.

So, they should appear as <iframe sandbox="allow-same-origin allow-scripts">.

Do you see any errors in console log?

No response

How to reproduce the issue?

  1. Navigate to https://compulim.github.io/webchat-loader/
  2. Type and send "video youtube" and "video vimeo"

What do you expect?

The <iframe> element should have sandbox="allow-same-origin allow-scripts" attribute.

What actually happened?

The <iframe> element does not have sandbox attribute.

Do you have any screenshots or recordings to repro the issue?

image

Adaptive Card JSON

No response

Additional context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugIndicates an unexpected problem or an unintended behavior.

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions