Convert projects to use FrameworkReference#2355
Merged
TimothyMothra merged 8 commits intodevelopfrom Aug 11, 2021
Merged
Conversation
added 2 commits
August 9, 2021 12:00
| <PackageReference Include="Microsoft.AspNetCore.Mvc.Core" Version="1.1.8" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup Condition=" '$(TargetFramework)' == 'netcoreapp3.1' "> |
Member
There was a problem hiding this comment.
This is correct. By default all ASP.NET Core 2.1 app had IHostingEnvironment reference in startup.cs. As we are retiring .NET Core 2.1 we need to move from IHostingEnvironment to IWebHostEnvironment. This change is not simple, it requires modification to DefaultApplicationInsightsServiceConfigureOptions.cs. This is out of the scope for this PR.
rajkumar-rangaraj
approved these changes
Aug 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Issue #2251
This affects test projects.
Our SDKs target NetStandard2.0, but our Test projects target individual frameworks.
Changes
Checklist
For significant contributions please make sure you have completed the following items:
The PR will trigger build, unit tests, and functional tests automatically. Please follow these instructions to build and test locally.
Notes for authors:
Notes for reviewers:
/AzurePipelines runwill queue all builds/AzurePipelines run <pipeline-name>will queue a specific build