updating netcore and variables for AspNetCore.Tests#1810
Merged
TimothyMothra merged 9 commits intomicrosoft:developfrom Apr 25, 2020
eddynaka:feature/updating-netcore-applicationinsights-aspnetcore
Merged
updating netcore and variables for AspNetCore.Tests#1810TimothyMothra merged 9 commits intomicrosoft:developfrom eddynaka:feature/updating-netcore-applicationinsights-aspnetcore
TimothyMothra merged 9 commits intomicrosoft:developfrom
eddynaka:feature/updating-netcore-applicationinsights-aspnetcore
Conversation
adding netcoreapp3.1 as targetframework as well
TimothyMothra
approved these changes
Apr 24, 2020
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
TimothyMothra
suggested changes
Apr 24, 2020
TimothyMothra
left a comment
There was a problem hiding this comment.
Hey Eddy, AspNetCore has a .yml file which is the build instructions for linux.
This needs to be updated as well.
The changes will be similar to the changes I made for Microsoft.ApplicationInsights SDK.
Ping me if you have questions.
This comment has been minimized.
This comment has been minimized.
updating package condition
reorganize sections to be descending frameworks (v3, v2) add comments. remove hardcoded framework versions in favor of version wildcard
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
Author
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
TimothyMothra
approved these changes
Apr 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Issue #1769