Closed
Conversation
added 16 commits
January 30, 2020 16:03
add new environment variable, and cleanup tests
cijothomas
reviewed
Mar 25, 2020
.../Microsoft.ApplicationInsights/Extensibility/Implementation/TelemetryConfigurationFactory.cs
Outdated
Show resolved
Hide resolved
cijothomas
reviewed
Mar 25, 2020
.../Microsoft.ApplicationInsights/Extensibility/Implementation/TelemetryConfigurationFactory.cs
Outdated
Show resolved
Hide resolved
cijothomas
reviewed
Mar 25, 2020
...icrosoft.ApplicationInsights/Extensibility/Implementation/Tracing/SelfDiagnosticsProvider.cs
Outdated
Show resolved
Hide resolved
cijothomas
reviewed
Mar 25, 2020
...icrosoft.ApplicationInsights/Extensibility/Implementation/Tracing/SelfDiagnosticsProvider.cs
Outdated
Show resolved
Hide resolved
cijothomas
reviewed
Mar 25, 2020
...t.ApplicationInsights/Extensibility/Implementation/Tracing/FileDiagnosticsTelemetryModule.cs
Outdated
Show resolved
Hide resolved
cijothomas
reviewed
Mar 25, 2020
...t.ApplicationInsights/Extensibility/Implementation/Tracing/FileDiagnosticsTelemetryModule.cs
Outdated
Show resolved
Hide resolved
cijothomas
reviewed
Mar 25, 2020
...icrosoft.ApplicationInsights/Extensibility/Implementation/ConfigString/ConfigStringParser.cs
Outdated
Show resolved
Hide resolved
cijothomas
reviewed
Mar 25, 2020
...t.ApplicationInsights/Extensibility/Implementation/Tracing/FileDiagnosticsTelemetryModule.cs
Outdated
Show resolved
Hide resolved
cijothomas
requested changes
Mar 25, 2020
Contributor
cijothomas
left a comment
There was a problem hiding this comment.
Did a quick review and left comments. I think more commits are pending to this?
4 tasks
9 tasks
added 8 commits
August 11, 2020 15:34
…ft/ApplicationInsights-dotnet into tilee/config_diagnostics
cijothomas
reviewed
Aug 17, 2020
....ApplicationInsights.Tests/Extensibility/TelemetryConfigurationFactorySelfDiagnosticTests.cs
Outdated
Show resolved
Hide resolved
cijothomas
reviewed
Aug 17, 2020
BASE/src/Microsoft.ApplicationInsights/Extensibility/Implementation/Tracing/CoreEventSource.cs
Outdated
Show resolved
Hide resolved
cijothomas
reviewed
Aug 17, 2020
...tionInsights/Extensibility/Implementation/Tracing/DiagnosticsModule/FileDiagnosticsSender.cs
Outdated
Show resolved
Hide resolved
added 3 commits
August 17, 2020 17:01
cijothomas
reviewed
Aug 18, 2020
| /// <summary> | ||
| /// This class encapsulates parsing and interpreting the self diagnostics configuration string. | ||
| /// </summary> | ||
| internal class SelfDiagnosticsProvider |
Contributor
There was a problem hiding this comment.
the name "Provider" does not sound correct.
cijothomas
reviewed
Aug 18, 2020
| this.Senders.Add(new PortalDiagnosticsQueueSender()); | ||
|
|
||
| this.FileDiagnosticsSender = new FileDiagnosticsSender(); | ||
| this.Senders.Add(this.FileDiagnosticsSender); |
Contributor
There was a problem hiding this comment.
we are likely missing logs before initialization. Probably need similar approach as portalqueue to keep them in memory until a config is available.
cijothomas
reviewed
Aug 18, 2020
| private readonly DefaultTraceListener defaultTraceListener = new DefaultTraceListener(); | ||
|
|
||
| private string logDirectory = Environment.ExpandEnvironmentVariables("%TEMP%"); | ||
| private bool isEnabled = false; // TODO: NEED MORE PERFORMANT FILE WRITTER BEFORE ENABLING THIS BY DEFAULT |
Contributor
There was a problem hiding this comment.
turning this on/off and what the default value should be - i think this should be the resposibility of DiagnosticmModule.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1981
Changes
FileDiagnosticsTelemetryModuleintoDiagnosticsTelemetryModuleChecklist
For significant contributions please make sure you have completed the following items:
The PR will trigger build, unit tests, and functional tests automatically. Please follow these instructions to build and test locally.
Notes for authors:
Notes for reviewers:
/AzurePipelines runwill queue all builds/AzurePipelines run <pipeline-name>will queue a specific build