Cache sdk version string#896
Merged
Merged
Conversation
simplified string builder usage.
added missing break statement.
dhaval24
reviewed
Apr 2, 2019
dhaval24
reviewed
Apr 2, 2019
dhaval24
reviewed
Apr 2, 2019
deleted locales.properties since that was for the java 6 fall-through
trask
approved these changes
Apr 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We read the values in
sdk-version.propertiesandstarter-version.propertiesmultiple times during the life of the SDK. This eliminates the need for opening/closing the stream each time the value is read and consolidates some common code.@dhaval24 @reyang Please comment on the FIXME/TODOs. I hope to remove those before merging.
Also, @dhaval24, make sure the
breakinSpringBootHeartbeatProvideris correct. It appeared to be missing.