removed dependency on guava#803
Merged
Merged
Conversation
replaced any methods used with apache-commons
Contributor
Author
|
Waiting on smoke tests to run against this branch before merge |
dhaval24
approved these changes
Jan 17, 2019
dhaval24
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. Let the build pass and you can merge. Make sure you have updated all the build.gradle files where guava was referenced.
Contributor
|
@littleaj is there anything left before we can merge this? I would suggest to have a patch release of SDK if possible with this security fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apache-commons has all the utilites we need.
Fix #799 .